Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo and spelling #102

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Fix typo and spelling #102

merged 1 commit into from
Nov 21, 2024

Conversation

b-a-t
Copy link
Contributor

@b-a-t b-a-t commented Nov 21, 2024

What does this PR do?

Fix documentation

What issues does this PR fix or reference?

Fixes:

auth:token makes sense only when auth:method is set to token. I believe approle here is a c-n-p error.

Grammarly suggests that the word should be spelt significance in this case.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

`auth:token` makes sense only when `auth:method` is set to `token`. I believe `approle` here is a c-n-p error.

Grammarly suggests that the word should be spelt `significance` in this case.
Copy link
Member

@lkubb lkubb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (e757fb5) to head (c522598).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files          79       79           
  Lines       13231    13231           
  Branches     1224     1224           
=======================================
  Hits        12018    12018           
  Misses        953      953           
  Partials      260      260           
Flag Coverage Δ
Linux 90.75% <ø> (ø)
macOS 66.40% <ø> (ø)
project 80.49% <ø> (ø)
py310 90.78% <ø> (ø)
py39 85.48% <ø> (ø)
salt_3006_9 85.55% <ø> (ø)
salt_3007_1 90.74% <ø> (ø)
tests 95.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lkubb lkubb merged commit f7204c9 into salt-extensions:main Nov 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants